DataViews: Add density option to table layout
#67170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @annchichi. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +549 B (+0.03%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ntsekouras
requested review from
youknowriad,
mcsf,
oandregal,
jameskoster and
jasmussen
4 tasks
ntsekouras
force-pushed
the
dataviews/add-table-density
branch
from
fe0ada1 to
77f3a3f
Compare
ntsekouras
commented
Nov 21, 2024
| return _density; | ||
| } ); | ||
| }, [ setDensity, viewport ] ); | ||
| const gridColumns = view.layout?.gridColumns; |
There was a problem hiding this comment.
This effect was changed to a hook and essentially changes conditionally the grid columns on viewport change.
Before it was only effective when the view options dropdown was open, so I'm using it at the main grid layout code.
Screen.Recording.2024-11-21.at.10.17.43.AM.mov
ntsekouras
commented
Nov 21, 2024
| @@ -169,6 +169,21 @@ | |||
| opacity: 1; | |||
| } | |||
| } | |||
|
|
|||
| // Density style overrides. | |||
| &.has-compact-density { | |||
There was a problem hiding this comment.
This is where we'll add the density styles.
There was a problem hiding this comment.
This is where we'll add the density styles.
@ntsekourasI was wondering if it’s possible for a density style to include a different type size (within the defined typesscale), or is it limited to just spacing variants like padding?
There was a problem hiding this comment.
include a different type size
You mean font sizes? In general I added these changes as a placeholder and designers will decide how the table should look per density.
|
@ntsekouras the screen recording looks awesome and I think the density settings will be very useful to our users :) |
oandregal
reviewed
Nov 21, 2024
packages/dataviews/src/components/dataviews-view-config/index.tsx
Outdated
Show resolved
Hide resolved
oandregal
reviewed
Nov 21, 2024
| density={ density } | ||
| setDensity={ setDensity } | ||
| /> | ||
| { !! usedLayout?.viewConfigOptions && ( |
There was a problem hiding this comment.
Consumers can provide default data for the density via view.layout.density. That's nice. How could they disable this layout-specific config so it still takes a value (e.g.: compact) and users cannot change it?
There was a problem hiding this comment.
Good question! It feels like we'd need a new API for something like that, no? Maybe something like what Query Loop does?
There was a problem hiding this comment.
Not sure how that translates to a DataView concept, could you ellaborate? :)
There was a problem hiding this comment.
Maybe it could be by having an extra prop in view.layout which could be something like view.layout.renderControls: ['density']. Having an empty array there could mean do not render any viewConfigOptions. I think we'd need a bit more time to see how viewConfigOptions evolves to start exploring a good way to support this.
There was a problem hiding this comment.
That could work, though we need to figure out a few things:
- sort & order are configured by the Field API: if no field is sortable they won't be available
- pagination & field config (moving but also field visibility) cannot be disabled and are controlled by the view config component
- the view config doesn't have information about the layout-specific view configs (density, preview size)
oandregal
reviewed
Nov 21, 2024
youknowriad
reviewed
Nov 21, 2024
youknowriad
reviewed
Nov 21, 2024
youknowriad
reviewed
Nov 21, 2024
ntsekouras
force-pushed
the
dataviews/add-table-density
branch
from
d53a798 to
e41a211
Compare
jameskoster
approved these changes
Nov 25, 2024
jameskoster
reviewed
Nov 25, 2024
jameskoster
reviewed
Nov 25, 2024
| .fields-controls__featured-image-placeholder { | ||
| width: 32px; | ||
| height: 32px; | ||
| display: block; |
There was a problem hiding this comment.
Similar to the previous bug. The lack of display property was creating whitespace beneath the featured image which messed up alignment.
|
Flaky tests detected in e657fc8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12008079372
|
oandregal
reviewed
Nov 25, 2024
| @@ -35,7 +35,6 @@ import { useInstanceId } from '@wordpress/compose'; | |||
| */ | |||
| import { | |||
| SORTING_DIRECTIONS, | |||
| LAYOUT_GRID, | |||
There was a problem hiding this comment.
This is an improvement: we have only the LAYOUT_TABLE dependency here. 🎉
oandregal
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Resolves: #66312
This PR adds a
densityoption totablelayout. I first explored whether an abstraction for thedensityconcept could be a good fit for layouts, but after discussions and better consideration it's better not to rush to such abstraction. The main reason is thedensityforgridfor example might confuse users, because common expectations would be a clear setting for controlling the columns(preview size).Having said that, this PR adds a viewConfigOptions to layouts, where layouts can optionally add some specific controls (React components) in a specific place in the
view optionsdropdown.By doing that, we decouple the previews grid's
preview sizecontrol from the DataViews core components code and the layout is responsible for providing this control. Additionally these props have been moved insideview.layoutobject, since they are specific to each layout.Tasks
densitycontrol and available optionstablelayout perdensityoptionTesting instructions
densityoption intablelayoutpreview sizeoption in `grid layout (they should behave the same with trunk with an improvement to auto adjust when the viewport changes)Screenshots
Screen.Recording.2024-11-21.at.9.07.27.AM.mov